Compat: Skip texture sync tests that use storage textures if 0 #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
force-pushed
the
texture_sync
branch
from
9f8008a to
cee20e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear to me if writing to a storage texture is important for the render-pass-encoder and render-bundle-encoder or if there should be more cases
Right now
render-pass-encoderandrender-bundle-encoderwrite directly to a storage texture, another case could instead render to that texture instead as a colorAttachment. I guess that's covered by theattachment-storeandattachment-resolvecases though.In any case, this PR makes the test skip using storage textures if the device doesn't have any.