Fix DeviceModifier #4103
Merged
Fix DeviceModifier #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Dec 18, 2024
The issue is the key is selected before the modification happens which means the devices in the pool will not match the key. I can't think of a way to fix this using the adaptor so maybe this hacky solution works by letting you modify the key. Generally you just append a string but I made it function because MaxLimitsTestMixin wants to be able to chain to other modifiers. Maybe it should all be re-designed This came up because I notice a test passing that shouldn't have passed. It passsed because a `MaxLimitsTestMixin` test ran first and it's key was `''` which meant that other tests got a max limits device from the pool.
greggman
force-pushed
the
fix-descritor-modifier
branch
from
1f3ac76 to
dda7198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is the key is selected before the modification happens which means the devices in the pool will not match the key.
I can't think of a way to fix this using the adaptor so maybe this hacky solution works by letting you modify the key.
Generally you just append a string but I made it function because MaxLimitsTestMixin wants to be able to chain to other modifiers.
Maybe it should all be re-designed
This came up because I notice a test passing that shouldn't have passed. It passsed because a
MaxLimitsTestMixintest ran first and it's key was''which meant that other tests got a max limits device from the pool.