Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen_wpt_cts_html: Add support for filtering the list of variants #4102

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

kainino0x
Copy link
Collaborator

Adds a new sample config file gen_wpt_cfg_withsomeworkers.json.

Note building this is really slow (it iterates the whole test tree four times) but it's still useful to have prebuilt and verified on presubmit, so I'm just including it in the build. Hopefully it's not prohibitively slow for anyone's local development (they should not need to run the whole npm test/npx grunt pre build often, hopefully). On my nice fast mac, npm test CPU time goes from 267s to 307s, but wall time goes from 69s to 72s thanks to parallelization.

To run just this one step: ./tools/gen_wpt_cts_html tools/gen_wpt_cfg_withsomeworkers.json
Running locally, the result files seem to be as expected (out-wpt/cts-withsomeworkers.https.html and gen/webgpu_variant_list_withsomeworkers.json).

The list of tests here is actually a superset of those [used by chromium](https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/webgpu-cts/worker_test_globs.txt]; I don't remember why we don't run all of these.

Issue: #4098
cc @ErichDonGubler


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [n/a] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [n/a] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located in the test tree.
  • [n/a] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x requested a review from greggman December 17, 2024 22:37
@kainino0x kainino0x enabled auto-merge (squash) December 18, 2024 05:44
@kainino0x kainino0x merged commit 5cb27b2 into gpuweb:main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants