Compat: skip memory_sync buffer tests when no support #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
force-pushed
the
buffer_sync
branch
from
0349357 to
15b739a
Compare
|
FYI I will be ooo starting tomorrow till new year and won't be available too much on github review |
At a glance I doesn't seem like there is anything to refactor here. The test that are actually using storage buffers need storage buffers. So, skip them if there are none.
greggman
force-pushed
the
buffer_sync
branch
from
15b739a to
576bc30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a glance I doesn't seem like there is anything to refactor here. The test that are actually using storage buffers need storage buffers. So, skip them if there are none.