Compat: refactor pipeline_bind_group_compat test for 0 storage buffers #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekshao
approved these changes
Dec 16, 2024
shrekshao
reviewed
Dec 16, 2024
| t.isCompatibility && | ||
| textureType === 'storage' && | ||
| !(t.device.limits.maxStorageBuffersInFragmentStage! > 2) | ||
| ); |
There was a problem hiding this comment.
nit: better have a message like the other pull requests indicating reason for skipping
greggman
force-pushed
the
compat_pipeline_bind_group_compat
branch
from
d9ae9a2 to
3586d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There's another test called
pipeline_bind_group_compatin thewebgpu:apitree. This one is in thewebgpu:compattree