Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: refactor depth_clip_clamp for 0 storage buffers #4096

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Dec 16, 2024

ps: these tests fail on mac before this change - tested them on linux and they pass with and without storage buffers

@greggman greggman requested a review from kainino0x December 16, 2024 06:52
@kainino0x
Copy link
Collaborator

ps: these tests fail on mac before this change - tested them on linux and they pass with and without storage buffers

I believe that's https://crbug.com/42240578

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman enabled auto-merge (squash) December 18, 2024 13:42
@greggman greggman disabled auto-merge December 18, 2024 13:48
@greggman greggman enabled auto-merge (squash) December 18, 2024 13:48
@greggman greggman merged commit bdee22a into gpuweb:main Dec 18, 2024
1 check passed
@greggman greggman deleted the depth_clip_clamp branch December 18, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants