Refactor discard test for no storage buffers #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Still reviewing, but what do you you think instead about making the choice between framebuffer and storage buffer a subcase to each test and skip the storage buffer version on compat implementations that don't support them? To me, the benefit would be that the same tests are run everywhere so and it's not the case that the test functions differently depending on the hardware. It also ensures we cover discard functionality more thoroughly.
|
sgtm. i"ll update |
|
updated. please take a look. |
|
ah, I made them cases, would you prefer subcases? There appears to be only one expectation in dawn related to this and it should be fine is I think. |
alan-baker
approved these changes
Dec 17, 2024
greggman
force-pushed
the
fix-discard
branch
from
06369f2 to
3db3caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.