Refactor derivative tests for 0 storage buffers. #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
force-pushed
the
fragment-builtins
branch
from
17e70dc to
3c9d1cc
Compare
jrprice
reviewed
Dec 13, 2024
src/webgpu/shader/execution/expression/call/builtin/derivatives.ts
Outdated
Show resolved
Hide resolved
src/webgpu/shader/execution/expression/call/builtin/derivatives.ts
Outdated
Show resolved
Hide resolved
greggman
force-pushed
the
fragment-builtins
branch
from
ef083b5 to
fdad507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey James, I'm trying to go through and refactor tests to not require storage buffers in vertex and fragment shaders where possible.
Most of the time, that means
setViewport