Refactor texture builtin for 0 vert/frag storage bufs/tex. #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
force-pushed
the
zero-sbstfsvs-more
branch
2 times, most recently
from
a01aef1 to
144be73
Compare
shrekshao
approved these changes
Dec 16, 2024
| ); | ||
| t.skipIf( | ||
| stage === 'v' && !(t.device.limits.maxStorageTexturesInVertexStage! > 0), | ||
| 'device does not support storage textures in fragment shaders' |
There was a problem hiding this comment.
'fragment shaders' -> 'vertex shaders'
| ); | ||
| this.skipIf( | ||
| stage === 'vertex' && !(this.device.limits.maxStorageTexturesInVertexStage! > 0), | ||
| 'device does not support storage textures in fragment shaders' |
There was a problem hiding this comment.
'fragment shaders' -> 'vertex shaders'
Update textureLoad and textureStore to handle the case where the device supports 0 storage buffers in fragment and vertex stages. Refactor texture.ts copyBufferToTextureViaRender so it doesn't use a storage buffer. Instead we use a r32float/r32sint/r32uint 1024x??? texture and treat it as a 1d array.
greggman
force-pushed
the
zero-sbstfsvs-more
branch
from
144be73 to
9ab4797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update textureLoad and textureStore to handle the case where the device supports 0 storage buffers in fragment and vertex stages.
Refactor texture.ts copyBufferToTextureViaRender so it doesn't use a storage buffer. Instead we use a r32float/r32sint/r32uint 1024x??? texture and treat it as a 1d array.