Remove many test cases that never run because maxColorAttachments=8 #4087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team noticed these because they were spamming a ton of output to the test logs.
These cases were trying to test more than 8 color attachments, but all of these tests run against the default adapter so
maxColorAttachments
is always 8.Unfortunately it's hard to exactly test this because Dawn never exposes more than 8 color attachments. (But it does expose 4 in compat, and those still work.) Anyway I'm pretty certain by inspection that none of these tests ever request higher limits.
As an aside, reduces the verbosity of the subcase names in
attachment_compatibility.spec.ts
.Issue: None, but introduces some TODOs for #3363
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.