Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove many test cases that never run because maxColorAttachments=8 #4087

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Dec 11, 2024

Our team noticed these because they were spamming a ton of output to the test logs.

These cases were trying to test more than 8 color attachments, but all of these tests run against the default adapter so maxColorAttachments is always 8.

Unfortunately it's hard to exactly test this because Dawn never exposes more than 8 color attachments. (But it does expose 4 in compat, and those still work.) Anyway I'm pretty certain by inspection that none of these tests ever request higher limits.

As an aside, reduces the verbosity of the subcase names in attachment_compatibility.spec.ts.

Issue: None, but introduces some TODOs for #3363


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x marked this pull request as ready for review December 11, 2024 05:35
@kainino0x kainino0x requested a review from greggman December 11, 2024 05:35
Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this rather change to use MaxLimitsTestMixin?

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Didn't bother to look in detail. I see this is a temp fix and is listed as a TODO to make it the correct fix. I'll review as is.

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kainino0x kainino0x enabled auto-merge (squash) December 11, 2024 05:50
@kainino0x kainino0x merged commit 1e545f5 into main Dec 11, 2024
1 check passed
@kainino0x kainino0x deleted the attachment_compatibility-too-verbose branch December 11, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants