Move MaxLimitsTest to MaxLimitTestMixin #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Dec 10, 2024
src/webgpu/gpu_test.ts
Outdated
| /** | ||
| * A Test that requests all the max limits from the adapter on the device. | ||
| */ | ||
| export class MaxLimitsTest extends GPUTest { | ||
| export class MaxLimitsTest2 extends GPUTest { |
There was a problem hiding this comment.
nit: Why 2? Is this used at all?
There was a problem hiding this comment.
Doh, sorry, Just forgot to delete it.
I wanted to use MaxLimitsTest with resource_compatibility.spec.ts but that file's tests are based on `CreateRenderPipelineValidationTest` which itself is based on `ValidationTest` and so would force making `ValidationTest` be based on `MaxLimitsTest`. I actually think thats a good idea. The default should be max limits. But, it breaks too many things. So, MaxLimitsTest a mixin.
greggman
force-pushed
the
max-limits-mixin
branch
from
688cb09 to
231da71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use
MaxLimitsTestwithresource_compatibility.spec.tsbut that file's tests are based onCreateRenderPipelineValidationTestwhich itself is based onValidationTestand so would force makingValidationTestbe based onMaxLimitsTest. I actually think thats a good idea. The default should be max limits. But, it breaks too many things.So, max MaxLimitsTest a mixin.