Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back unicode for texture diagrams #4074

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Dec 5, 2024

Example:

       0   1   2   3
     ╔═══╤═══╦═══╤═══╗
   0 ║ a │   ║   │   ║
     ╟───┼───╫───┼───╢
   1 ║   │   ║   │   ║
     ╠═══╪═══╬═══╪═══╣
   2 ║   │   ║   │   ║
     ╟───┼───╫───┼───╢
   3 ║   │   ║   │ b ║
     ╚═══╧═══╩═══╧═══╝

Unicode was removed here: #4008
Since then, outlining blocks was added here: #4053
So it's not just a revert.

Chrome's CQ appears to be happy with this now. example1 example2 example3 (search for "got: above")

@greggman greggman requested a review from kainino0x December 5, 2024 05:48
@greggman greggman force-pushed the add-back-unicode branch 3 times, most recently from 42e4075 to d267071 Compare December 9, 2024 06:00
Example:

```
       0   1   2   3
     ╔═══╤═══╦═══╤═══╗
   0 ║ a │   ║   │   ║
     ╟───┼───╫───┼───╢
   1 ║   │   ║   │   ║
     ╠═══╪═══╬═══╪═══╣
   2 ║   │   ║   │   ║
     ╟───┼───╫───┼───╢
   3 ║   │   ║   │ b ║
     ╚═══╧═══╩═══╧═══╝
```
@greggman greggman enabled auto-merge (squash) December 10, 2024 00:26
@greggman greggman merged commit 58d5109 into gpuweb:main Dec 10, 2024
1 check passed
@greggman greggman deleted the add-back-unicode branch December 10, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants