Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move towards deprecating subgroups_f16 enable (feature #4072

Conversation

petermcneeleychromium
Copy link
Contributor

We are deprecating the 'subgroups_f16' enable
One will only need 'f16' and 'subgroups' enables to use f16 subgroups operations.

Going forward the 'subgroups_f16' enable will have no effect. Eventually we want to remove this enable.

https://github.com/gpuweb/gpuweb/blob/main/proposals/subgroups.md

crbug.com/380862306

@petermcneeleychromium
Copy link
Contributor Author

Conclusion from meeting. Simply delete the tests that check for the requirements of subgroup_f16
(this is because we dont want to force this deprecation behavior on all implementers of webgpu)

Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I assume there will be more followups to remove enable subgroups_f16 from other tests that are still using it.

@petermcneeleychromium petermcneeleychromium merged commit b05322e into gpuweb:main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants