Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgsl] Add two more statement behavior test cases #4071

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jrprice
Copy link
Contributor

@jrprice jrprice commented Dec 3, 2024

These cover unreachable code after statements with return behavior for functions that have non-void return types, which were not previously covered and not handled correctly in Tint.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

These cover unreachable code after statements with `return` behavior
for functions that have non-void return types, which were not
previously covered and not handled correctly in Tint.
@jrprice jrprice added the wgsl label Dec 3, 2024
@jrprice jrprice requested a review from alan-baker December 3, 2024 16:53
@jrprice jrprice merged commit 3818ac8 into gpuweb:main Dec 3, 2024
1 check passed
@jrprice jrprice deleted the unreachable-after-return branch December 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants