Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of subgroup_uniformity diagnostic #4066

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

alan-baker
Copy link
Contributor

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested review from jrprice and dneto0 November 27, 2024 18:12
@alan-baker alan-baker requested a review from dneto0 November 29, 2024 19:13
@alan-baker alan-baker force-pushed the subgroup-uniformity-diagnostic branch from 8c74f13 to 85767fd Compare December 2, 2024 19:44
@alan-baker alan-baker force-pushed the subgroup-uniformity-diagnostic branch from 85767fd to dbb53eb Compare December 3, 2024 19:59
@alan-baker alan-baker enabled auto-merge (squash) December 3, 2024 19:59
@alan-baker alan-baker merged commit ca6d65d into gpuweb:main Dec 3, 2024
1 check passed
@alan-baker alan-baker deleted the subgroup-uniformity-diagnostic branch December 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants