-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation tests for early eval errors in subgroup builtins #4065
Conversation
src/webgpu/shader/validation/expression/call/builtin/subgroupShuffle.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/shader/validation/expression/call/builtin/subgroupShuffle.spec.ts
Outdated
Show resolved
Hide resolved
This covers the functions subgroupShuffle, subgroupShuffleUp, subgroupShuffleDown, and subgroupShuffleXor. There is a CTS in the works: gpuweb/cts#4065 Bug: 380862306 Change-Id: I0077557f62b4140bcbdd8601cbe6bc0a1933cf56 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/217074 Reviewed-by: dan sinclair <[email protected]> Commit-Queue: Peter McNeeley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks
* subgroupBroadcast and quadBroadcast id must be in range [0, 128) * subgroupShuffleUp, subgroupShuffleDown, subgroupShuffleXor mask/delta must be less than 128 for const/override
* Add negative value test for subgroupShuffle
b454027
to
fb9750b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets get this in. I can resolve potential issues on the dawn side in combination with my recent changes.
My concern here is if the Overrides are going to work correctly.
Note: the shuffle parameters are required to be u32, so negative values are impossible.
Issue: #
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.