Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformity tests for subgroup built-in functions #4064

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Nov 27, 2024

  • Built-in values already tested
  • Tests call site requirements and parameter requirements

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested review from jrprice and dneto0 November 27, 2024 15:26
var<private> non_uniform : u32 = 0;

@group(0) @binding(0)
var<storage> uniform : u32;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the variable name is slightly confusing because it shadows the address space by the same name.

But I see why you use a variable at all; it's a tighter rule to check than a const.

* Built-in values already tested
* Tests call site requirements and parameter requirements
@alan-baker alan-baker enabled auto-merge (squash) November 29, 2024 19:10
@alan-baker alan-baker merged commit fe65191 into gpuweb:main Nov 29, 2024
1 check passed
@alan-baker alan-baker deleted the subgroup-uniformity branch November 29, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants