Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readTextureToTextureViews for multisampled textures #4049

Merged

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Nov 19, 2024

I'm not sure when this bug was introduced. The tests this broke used to pass (textureLoad:multisampled). Fixed the bug and added a test to hopefully find it quicker if it breaks in the future.

Also added a test for createTextureWithRandomDataAndGetTexels with a generator. This was fixed in a previous PR without a a specific test as the fact that it failed other tests showed it needed fixing but I decided it's probably best to keep these tests too.

@greggman greggman requested a review from kainino0x November 19, 2024 22:06
@greggman greggman enabled auto-merge (squash) November 19, 2024 23:21
I'm not sure when this bug was introduced. These tests used
to pass. Fixed the bug and Added a test to hopefully find it
quicker if it breaks in the future.

Also added a test for createTextureWithRandomDataAndGetTexels
with a generator. This was fixed in a previous PR without a
a specific test as the fact that it failed other tests showed
it needed fixing but I decided it's probably best to keep
these tests too.
@greggman greggman force-pushed the fix-readTextureToTexelViews-multisampled branch from e018013 to 1383d3f Compare November 19, 2024 23:26
@greggman greggman merged commit 003cb57 into gpuweb:main Nov 19, 2024
1 check passed
@greggman greggman deleted the fix-readTextureToTexelViews-multisampled branch November 20, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants