Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic): expect success on duplicate validation if severities are the same #4042

Conversation

ErichDonGubler
Copy link
Member

Issue: #4041


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@ErichDonGubler ErichDonGubler added the bug Something isn't working label Nov 14, 2024
@ErichDonGubler ErichDonGubler self-assigned this Nov 14, 2024
@ErichDonGubler ErichDonGubler force-pushed the diagnostic-no-conflict-if-same-severity branch from 757155c to 615eb67 Compare November 14, 2024 00:34
@alan-baker
Copy link
Contributor

See #4041 (comment).

@ErichDonGubler
Copy link
Member Author

See #4041 (comment).

@ErichDonGubler ErichDonGubler deleted the diagnostic-no-conflict-if-same-severity branch November 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants