Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make textureGather/Compare not load weights #4018

Merged

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Oct 30, 2024

textureGather and textureGatherComapre do not use GPU mix weights so don't load them. This will make these test run on Intel Mac compute stage where the weights are bad.

@greggman greggman requested a review from shrekshao October 30, 2024 18:54
@greggman greggman force-pushed the textureGather-remove-level-weights-usage branch 2 times, most recently from 72913f3 to b8737eb Compare October 30, 2024 19:12
textureLoad and textureGather and textureGatherComapre do not use GPU mix weights
so don't load them. This will make the these test run on Intel Mac
compute stage where the weights are bad.
@greggman greggman force-pushed the textureGather-remove-level-weights-usage branch from b8737eb to 959b539 Compare October 30, 2024 20:31
@greggman greggman enabled auto-merge (squash) October 30, 2024 20:32
@greggman greggman merged commit 30ee073 into gpuweb:main Oct 30, 2024
1 check passed
@greggman greggman deleted the textureGather-remove-level-weights-usage branch October 30, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants