Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subgroupAdd and subgroupMul execution tests #4013

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

alan-baker
Copy link
Contributor

  • Use kDataSentinel instead of 999

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested review from dj2 and dneto0 October 28, 2024 01:28
* Use kDataSentinel instead of 999
@alan-baker alan-baker changed the title Fix subgroupAdd execution tests Fix subgroupAdd and subgroupMul execution tests Oct 28, 2024
@dneto0 dneto0 merged commit 45757be into gpuweb:main Oct 28, 2024
1 check passed
@alan-baker alan-baker deleted the fix-subgroup-add branch October 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants