Texture builtins: move addressMode? to case #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
lgtm! Sorry for the dumb restriction, it originally comes from when we were using WPT to run these tests in Chromium, which we aren't anymore, but I'm pretty sure that at least WebKit runs into similar issues for the same reason (though file path limits on Mac are surely not as bad as Windows)
addressMode is broken on many GPUs. Moving this from a subcase to a case lets us separate out those failures. I opted to put the parameters in minFilter, addresMode, offset order which means for some builtins I moved minFilter from subcase to case. This turned into a massive change because the queryStrings got too long. so had to change * addressModeX -> modeX * filter to filt * clamp-to-edge -> c * repeat -> r * mirror-repeat -> m * viewDimension -> dim * fragment -> f * compute -> c * vertex -> v Other option would be to move all the tests from `webgpu:shader,execution,expression,call,builtin` to `webgpu:texture` though I'm not sure that would be enough on it's own Note: this takes `webgpu:shader,execution,expression,call,builtin,*` from 21738 cases to 113546 cases
greggman
force-pushed
the
texture-builtins-separate-addressMode
branch
from
c644270 to
5ce03df
Compare
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
addressMode is broken on many GPUs. Moving this from a subcase to a case lets us separate out those failures. I opted to put the parameters in minFilter, addresMode, offset order which means for some builtins I moved minFilter from subcase to case. This turned into a massive change because the queryStrings got too long. so had to change * addressModeX -> modeX * filter to filt * clamp-to-edge -> c * repeat -> r * mirror-repeat -> m * viewDimension -> dim * fragment -> f * compute -> c * vertex -> v Other option would be to move all the tests from `webgpu:shader,execution,expression,call,builtin` to `webgpu:texture` though I'm not sure that would be enough on it's own Note: this takes `webgpu:shader,execution,expression,call,builtin,*` from 21738 cases to 113546 cases
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
addressMode is broken on many GPUs. Moving this from a subcase to a case lets us separate out those failures. I opted to put the parameters in minFilter, addresMode, offset order which means for some builtins I moved minFilter from subcase to case. This turned into a massive change because the queryStrings got too long. so had to change * addressModeX -> modeX * filter to filt * clamp-to-edge -> c * repeat -> r * mirror-repeat -> m * viewDimension -> dim * fragment -> f * compute -> c * vertex -> v Other option would be to move all the tests from `webgpu:shader,execution,expression,call,builtin` to `webgpu:texture` though I'm not sure that would be enough on it's own Note: this takes `webgpu:shader,execution,expression,call,builtin,*` from 21738 cases to 113546 cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressMode is broken on many GPUs. Moving this from a subcase to a case lets us separate out those failures.
I opted to put the parameters in minFilter, addressMode, offset order which means for some builtins I moved minFilter from subcase to case.
This turned into a massive change because the query strings got too long. so had to change
Other option would be to move all the tests from
webgpu:shader,execution,expression,call,builtintowebgpu:texturethough I'm not sure that would be enough on its ownNote: this takes
webgpu:shader,execution,expression,call,builtin,*from 21738 cases to 113546 cases