Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batching for shader,validation,expression,call,builtin,*:values: #4001

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kainino0x
Copy link
Collaborator

Many of these tests have too many subcases, which run in parallel and can run out of resources. We can use batching to break tests into more cases (without having to break them up arbitrarily by the numeric values passed to builtins).

Not all of the values tests actually have more than 125 subcases; if they don't, then batch has no effect. I added batch to all of them anyway so that when tests are added in the future, they'll serve as an example and get copied over.

Hopefully helps with https://crbug.com/373478528
and https://crbug.com/373485785

Issue: None


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [n/a] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [skipped] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Many of these tests have too many subcases, which run in parallel and
can run out of resources. We can use batching to break tests into more
cases (without having to break them up arbitrarily by the numeric values
passed to builtins).

Not all of the :values: tests actually have more than 125 subcases; if
they don't, then `batch` has no effect. I added `batch` to all of them
anyway so that when tests are added in the future, they'll serve as an
example and get copied over.

Hopefully helps with https://crbug.com/373478528
and https://crbug.com/373485785
@kainino0x kainino0x requested a review from zoddicus October 15, 2024 04:01
@kainino0x kainino0x enabled auto-merge (squash) October 15, 2024 18:54
@kainino0x kainino0x merged commit ec54937 into gpuweb:main Oct 15, 2024
1 check passed
@kainino0x kainino0x deleted the builtins-batching branch October 15, 2024 22:48
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
…puweb#4001)

Many of these tests have too many subcases, which run in parallel and
can run out of resources. We can use batching to break tests into more
cases (without having to break them up arbitrarily by the numeric values
passed to builtins).

Not all of the :values: tests actually have more than 125 subcases; if
they don't, then `batch` has no effect. I added `batch` to all of them
anyway so that when tests are added in the future, they'll serve as an
example and get copied over.

Hopefully helps with https://crbug.com/373478528
and https://crbug.com/373485785
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
…puweb#4001)

Many of these tests have too many subcases, which run in parallel and
can run out of resources. We can use batching to break tests into more
cases (without having to break them up arbitrarily by the numeric values
passed to builtins).

Not all of the :values: tests actually have more than 125 subcases; if
they don't, then `batch` has no effect. I added `batch` to all of them
anyway so that when tests are added in the future, they'll serve as an
example and get copied over.

Hopefully helps with https://crbug.com/373478528
and https://crbug.com/373485785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants