Include depth textures in more tests #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
requested review from
kainino0x and
shrekshao
and removed request for
kainino0x
Depth textures were excluded originally because there was no way to fill one via copyBufferToTexture. We added a way to fill them later which was used for the textureLoad tests. Now going back and enabling them for other tests. Note that might be better to move minFilter to a case instead of a subcase but that would break all expectations in CQs so it seemed best to filter these in the test itself.
greggman
force-pushed
the
include-depth-in-more-tests
branch
from
16909c3 to
4851306
Compare
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
Depth textures were excluded originally because there was no way to fill one via copyBufferToTexture. We added a way to fill them later which was used for the textureLoad tests. Now going back and enabling them for other tests. Note that might be better to move minFilter to a case instead of a subcase but that would break all expectations in CQs so it seemed best to filter these in the test itself.
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
Depth textures were excluded originally because there was no way to fill one via copyBufferToTexture. We added a way to fill them later which was used for the textureLoad tests. Now going back and enabling them for other tests. Note that might be better to move minFilter to a case instead of a subcase but that would break all expectations in CQs so it seemed best to filter these in the test itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth textures were excluded originally because there was no way to fill one via copyBufferToTexture. We added a way to fill them later which was used for the textureLoad tests. Now going back and enabling them for other tests.
Note that might be better to move minFilter to a case instead of a subcase but that would break all expectations in CQs so it seemed best to filter these in the test itself.