Get per stage GPU mix weights on demand #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be that mix weights for all stages were queried at initialization time. The problem is, on Intel Mac, the compute stage always fails. That means the majority of texture tests just would not run on Intel Mac, at least on Chrome and Firefox at the moment. Changing the code to load them per stage on demand means the texture builtin tests can run for compute and fragment stages on Intel Mac. You could argue this doesn't need to be fixed since Chrome and Firefox should fix their texture code on Intel Mac but I think at the moment there are a bunch more high priority things being worked on so it's best not to lose coverage for compute and fragment shaders.
greggman
force-pushed
the
get-mix-weights-on-demand
branch
from
b54b14a to
32b93dc
Compare
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
It used to be that mix weights for all stages were queried at initialization time. The problem is, on Intel Mac, the compute stage always fails. That means the majority of texture tests just would not run on Intel Mac, at least on Chrome and Firefox at the moment. Changing the code to load them per stage on demand means the texture builtin tests can run for compute and fragment stages on Intel Mac. You could argue this doesn't need to be fixed since Chrome and Firefox should fix their texture code on Intel Mac but I think at the moment there are a bunch more high priority things being worked on so it's best not to lose coverage for compute and fragment shaders.
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
It used to be that mix weights for all stages were queried at initialization time. The problem is, on Intel Mac, the compute stage always fails. That means the majority of texture tests just would not run on Intel Mac, at least on Chrome and Firefox at the moment. Changing the code to load them per stage on demand means the texture builtin tests can run for compute and fragment stages on Intel Mac. You could argue this doesn't need to be fixed since Chrome and Firefox should fix their texture code on Intel Mac but I think at the moment there are a bunch more high priority things being worked on so it's best not to lose coverage for compute and fragment shaders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be that mix weights for all stages were queried at initialization time. The problem is, on Intel Mac, the compute stage always fails. That means the majority of texture tests just would not run on Intel Mac, at least on Chrome and Firefox at the moment.
Changing the code to load them per stage on demand means the texture builtin tests can run for compute and fragment stages on Intel Mac.
You could argue this doesn't need to be fixed since Chrome and Firefox should fix their texture code on Intel Mac but I think at the moment there are a bunch more high priority things being worked on so it's best not to lose coverage for compute and fragment shaders.