Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test indexing of a matrix using non-const index #3982

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

sagudev
Copy link
Collaborator

@sagudev sagudev commented Oct 5, 2024

I think there is no such test in CTS and I need it to test gfx-rs/wgpu#6362. Test is based on code from webgpu:shader,execution,expression,access,array,index:runtime_sized:*.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. Passes in EDGE, not working on Firefox due to missing support in wgpu (reason for writing this).
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@sagudev
Copy link
Collaborator Author

sagudev commented Oct 16, 2024

Is anything blocking this?

@Kangz Kangz enabled auto-merge (squash) October 24, 2024 11:03
@Kangz Kangz merged commit d473d09 into gpuweb:main Oct 24, 2024
1 check passed
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
* Test indexing of a matrix using non-const index

Signed-off-by: sagudev <[email protected]>

* fixup

Signed-off-by: sagudev <[email protected]>

---------

Signed-off-by: sagudev <[email protected]>
Co-authored-by: Corentin Wallez <[email protected]>
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
* Test indexing of a matrix using non-const index

Signed-off-by: sagudev <[email protected]>

* fixup

Signed-off-by: sagudev <[email protected]>

---------

Signed-off-by: sagudev <[email protected]>
Co-authored-by: Corentin Wallez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants