Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTS test for new depthBias validation #3863

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Add CTS test for new depthBias validation #3863

merged 4 commits into from
Jul 17, 2024

Conversation

toji
Copy link
Member

@toji toji commented Jul 16, 2024

Adds tests for the new depthBias validation added in gpuweb/gpuweb#4743. Does not succeed on any browsers yet, but will succeed on Chrome once the deprecation period has passed.

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@toji toji requested review from kainino0x and shrekshao July 16, 2024 21:36
shrekshao
shrekshao approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toji toji merged commit 428adb4 into main Jul 17, 2024
1 check passed
@toji toji deleted the depth-bias-validation branch July 17, 2024 17:09
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Aug 5, 2024
@ErichDonGubler
WIP: Bug 1909753, part 2.4 - new backlog tests r=#webgpu-reviewers!
d164b73 
This adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- TODO: What else is in here?
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Aug 19, 2024
@ErichDonGubler
Bug 1909753, part 2.6 - new backlog tests r=#webgpu-reviewers
45c6e54 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Aug 19, 2024
@ErichDonGubler
Bug 1909753, part 2.6 - new backlog tests r=#webgpu-reviewers
e4e589b 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Aug 20, 2024
@ErichDonGubler
Bug 1909753, part 2.6 - new backlog tests r=#webgpu-reviewers
ee4149b 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 20, 2024
@ErichDonGubler
Bug 1909753, part 2.6 - new backlog tests r=webgpu-reviewers,teoxoy
1ca2b95 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 21, 2024
@ErichDonGubler
Bug 1909753, part 2.6 - new backlog tests r=webgpu-reviewers,teoxoy
b2c171e 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Aug 22, 2024
@ErichDonGubler
Bug 1909753, part 2.6 - new backlog tests r=webgpu-reviewers,teoxoy
1f04771 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Aug 23, 2024
@marco-c
Bug 1909753, part 2.6 - new backlog tests r=webgpu-reviewers,teoxoy
0e2ea54 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377

UltraBlame original commit: cc8e4c0d527650c82b7c8d07a4484856ea046c10
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Aug 23, 2024
@marco-c
Bug 1909753, part 2.6 - new backlog tests r=webgpu-reviewers,teoxoy
a1eff36 
This (non-exhaustively) adds or implements the following test paths:

- `webgpu:api,validation,render_pipeline,depth_stencil_state:depth_bias:*`, introduced by [gpuweb/cts#3863](gpuweb/cts#3863). Tracked with [bug 1911312](https://bugzilla.mozilla.org/show_bug.cgi?id=1911312).
- `webgpu:shader,execution,expression,access,array,index:matrix:*`, introduced by [gpuweb/cts#3738](gpuweb/cts#3738).
- `webgpu:shader,execution,expression,call,builtin,atomics,atomicSub:sub_i32_min:*`, introduced by [gpuweb/cts#3728](gpuweb/cts#3728).
- `webgpu:shader,execution,expression,call,builtin,fwidth{,Coarse,Fine}:f32:*`, implemented by [gpuweb/cts#3686](gpuweb/cts#3686).
- `webgpu:shader,execution,expression,call,builtin,textureNumLayers:arrayed:*`, implemented by [gpuweb/cts#3853](gpuweb/cts#3853).
- `webgpu:shader,execution,expression,call,builtin,textureNumLevels:sampled:*`, implemented by [gpuweb/cts#3855](gpuweb/cts#3855).
- `webgpu:shader,execution,expression,call,builtin,textureNumSamples:sampled:*`, implemented by [gpuweb/cts#3856](gpuweb/cts#3856).
- `webgpu:shader,execution,expression,call,builtin,textureLoad:*`, with:
	- `{arrayed,sampled_1d,sampled_3d}` implemented by [gpuweb/cts#3852](gpuweb/cts#3852)
	- `sampled_2d` implemented by [gpuweb/cts#3861](gpuweb/cts#3861).
- `webgpu:shader,execution,expression,call,builtin,textureSample:*`, apparently changed by [gpuweb/cts#3877](gpuweb/cts#3877).
- `webgpu:shader,execution,expression,call,builtin,textureStore:*` had the following tests added:
	- By [gpuweb/cts#3781](gpuweb/cts#3781):
		- `out_of_bounds`
		- `out_of_bounds_array`
	- By [gpuweb/cts#3841](gpuweb/cts#3841):
		- `bgra8unorm_swizzle`
		- `texel_formats`

	It's unclear why these are failing, but I suspect part 2.7.
- `webgpu:shader,execution,expression,constructor,zero_value:vector_prefix:*`, introduced by [gpuweb/cts#3734](gpuweb/cts#3734).
- `webgpu:shader,validation,decl,var:address_space_access_mode:*`, introduced by [`gpuweb/cts`#3695](gpuweb/cts#3695).
- `webgpu:shader,validation,decl,var:shader_stage:*`, introduced by [gpuweb/cts#3736](gpuweb/cts#3736).
- `webgpu:shader,validation,expression,access,vector:*` was modified in [gpuweb/cts#3708](gpuweb/cts#3708):
	- renamed `…:vector:*` to `concrete`
	- added `abstract`
- `webgpu:shader,validation,expression,binary,*`:
	- `…,bitwise_shift:*`:
		- `…:partial_eval_errors:*`, introduced by [`gpuweb/cts`#3796](gpuweb/cts#3796)
		- `…:{shift_left_concrete,shift_right_concrete}:*` had new cases introduced in [gpuweb/cts#3726](gpuweb/cts#3726).
		- `…:{shift_left_abstract,shift_right_abstract}:*`, introduced by [`gpuweb/cts`#3833](gpuweb/cts#3833).
	- `…,{add_sub_mul:*,and_or_xor:*,bitwise_shift:scalar_vector:*,div_rem:scalar_vector:*}` modified by [`gpuweb/cts`#3648](gpuweb/cts#3648).
- `webgpu:shader,validation,expression,call,builtin,*`:
	- `…,dot:*`, introduced in [gpuweb/cts#3579](gpuweb/cts#3579).
	- `…,fma:*`, introduced by [`gpuweb/cts`#3577](gpuweb/cts#3577).
	- `…,ldexp:*`:
		- `…:{args,must_use,values}:*` introduced by [gpuweb/cts#3615](gpuweb/cts#3615).
		- `…:partial_values:*` introduced by [gpuweb/cts#3798](gpuweb/cts#3798).
	- `…,mix:*`, introduced by TODO.
	- `…,modf:*`, introduced by TODO.
	- `…,pow:*`, introduced by TODO.
	- `…,refract:*`, introduced by TODO.
	- `…,saturate:*`, introduced by TODO.
	- `…,texture{Dimensions,Num{Layers,Levels,Samples}}:*`, introduced by [gpuweb/cts#3689](gpuweb/cts#3689).
- `webgpu:shader,validation,functions,alias_analysis:swizzles:*`, introduced by [gpuweb/cts#3869](gpuweb/cts#3869).
- `webgpu:shader,validation,shader_io,align:parsing:duplicate`, introduced by [gpuweb/cts#3692](gpuweb/cts#3692).
- `webgpu:shader,validation,statement,{for,loop,return}:*` cases introduced by [gpuweb/cts#3645](gpuweb/cts#3645) and moved around by [gpuweb/cts#3742](gpuweb/cts#3742).
- `webgpu:shader,validation,types,pointer:{access_mode,address_space,type}:*`, introduced by [`gpuweb/cts`#3649](gpuweb/cts#3649).

This list is incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219377

UltraBlame original commit: cc8e4c0d527650c82b7c8d07a4484856ea046c10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

@shrekshao shrekshao shrekshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toji @kainino0x @shrekshao