Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run batchFinishedCallback on processBatch to catch unhandled rejections by test functions #3844

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

sagudev
Copy link
Collaborator

@sagudev sagudev commented Jul 7, 2024

Issue: #3809 (I verified that it fixes the timeout issue in servo)

Related #3158, but I think this fix is more appropriate (and less invasive).


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@sagudev
Copy link
Collaborator Author

sagudev commented Jul 9, 2024

Care to review @kainino0x?

@kainino0x kainino0x self-requested a review July 13, 2024 00:40
@kainino0x
Copy link
Collaborator

Sorry, had this in my review inbox but been swamped this week!

@sagudev sagudev requested a review from kainino0x July 13, 2024 08:06
@kainino0x kainino0x enabled auto-merge (squash) July 15, 2024 17:53
@kainino0x kainino0x merged commit 20425f6 into gpuweb:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants