Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move builtin must_use tests to specific builtin tests #3745

Merged
merged 2 commits into from
May 15, 2024

Conversation

alan-baker
Copy link
Contributor

Fixes #3502

  • Moves must_use tests for builtin functions to specific files

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested a review from dj2 May 14, 2024 21:17
Fixes gpuweb#3502

* Moves must_use tests for builtin functions to specific files
@alan-baker alan-baker enabled auto-merge (squash) May 15, 2024 14:14
@alan-baker alan-baker merged commit 938c911 into gpuweb:main May 15, 2024
1 check passed
@alan-baker alan-baker deleted the must-use-3502 branch May 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Move builtin must_use tests into per-builtin validation suites
2 participants