Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth_clamp_and_clip test #3524

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Mar 18, 2024

Broken in #3412. Prior to this, some copies were being skipped for some formats because bytesPerBlock was undefined for those copies.
This doesn't change the coverage of the test though, as the actual check that used those copies is still skipped those copies were only used for pretty-printing.

I missed the regressions before because they were a bit buried in existing failures on my machine.

Issue: #2495


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Broken in gpuweb#3412. Prior to this, some checks were being skipped (that
we didn't want to skip, but were skipped because of the limitations of
the format info table).
@kainino0x kainino0x marked this pull request as draft March 18, 2024 19:23
@kainino0x kainino0x marked this pull request as ready for review March 18, 2024 19:27
@kainino0x kainino0x merged commit d568361 into gpuweb:main Mar 18, 2024
1 check passed
@kainino0x kainino0x deleted the depth-clip-clamp-fix branch March 18, 2024 19:27
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 18, 2024
Broken in gpuweb#3412. Prior to this, some copies were being skipped for some formats because bytesPerBlock was undefined for those copies.
This doesn't change the coverage of the test though, as the actual check that used those copies is still skipped.

I missed the regressions before because they were a bit buried in existing failures on my machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants