Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test validation of arg numbers and types, must_use for degrees, radia… #3516

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Mar 15, 2024

…ns, sqrt

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@dneto0 dneto0 requested a review from ben-clayton March 15, 2024 20:12
good: '(1.1)',
bad_no_parens: '',
// Bad number of args
bad_0args: '()',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 relates to number of arguments...

bad_0args: '()',
bad_2args: '(1.0,2.0)',
// Bad value type for arg 0
bad_0i32: '(1i)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and now 0 relates to the 0th index.

I still prefer my suggested names. 😝

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"too_few" and "too_many" would be an improvement, yes.
I'll adjust in followups.

@dneto0 dneto0 enabled auto-merge (rebase) March 18, 2024 18:56
@dneto0 dneto0 merged commit cd9decb into gpuweb:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants