Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup texture builtin WGSL validation tests #3511

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

greggman
Copy link
Contributor

Also add in_fragment_only tests that tests these builtins only work in the fragment shader.

I need to update textureSampleBias as well. textureSamplerBias needs a shader_stage_utils.ts from this PR though.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Also add in_fragment_only tests that tests these
builtins only work in the fragment shader.
@greggman greggman requested a review from ben-clayton March 14, 2024 23:54
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@greggman greggman merged commit 83eda31 into gpuweb:main Mar 14, 2024
1 check passed
@greggman greggman deleted the texture-builtin-wgsl-cleanup branch March 15, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants