Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSL Validation test for textureSampleCompareLevel #3510

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

greggman
Copy link
Contributor


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from ben-clayton March 14, 2024 21:11
@greggman greggman force-pushed the textureSampleCompareLevel branch 2 times, most recently from 24a858d to b036e04 Compare March 15, 2024 00:29
@greggman greggman force-pushed the textureSampleCompareLevel branch 2 times, most recently from cc2d2c3 to 96af0b6 Compare March 15, 2024 17:38
@greggman greggman enabled auto-merge (rebase) March 15, 2024 17:39
@greggman greggman force-pushed the textureSampleCompareLevel branch from 96af0b6 to 55bc38d Compare March 15, 2024 17:46
@greggman greggman merged commit 7372f8b into gpuweb:main Mar 15, 2024
1 check passed
@greggman greggman deleted the textureSampleCompareLevel branch March 15, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants