Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types,textures and bgra8unorm_storage tests #3507

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

shrekshao
Copy link
Contributor

Failing in chrome, related chrome impl update: https://dawn-review.googlesource.com/c/dawn/+/178923

  • Fix storage_texture_types for bgra8unorm test (force it to pass instead of relying on storage info from format_info)
  • Remove create_shader_module_with(out)_bgra8unorm_storage
  • Add sampled_texture_types

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@shrekshao shrekshao requested a review from jrprice March 14, 2024 20:41
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although in future I'd recommend splitting unrelated changes into separate PRs (e.g. bgra8unorm stuff and sampled texture tests would be two different PRs) .

@shrekshao shrekshao enabled auto-merge (squash) March 15, 2024 16:23
@shrekshao shrekshao merged commit 1042b2f into gpuweb:main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants