Add validation tests for statement behavior analysis#3506
Merged
alan-baker merged 3 commits intogpuweb:mainfrom Mar 15, 2024
Merged
Add validation tests for statement behavior analysis#3506alan-baker merged 3 commits intogpuweb:mainfrom
alan-baker merged 3 commits intogpuweb:mainfrom
Conversation
jrprice
approved these changes
Mar 15, 2024
Contributor
jrprice
left a comment
jrprice
left a comment
There was a problem hiding this comment.
LGTM with a couple of minor comments.
| for5: `for (;; return ) { }`, | ||
| for6: `for (;;) { continue; break; }`, | ||
| // while loops always have break in their behaviors. | ||
| switch1: `switch (1) { case 1 { } }`, |
Contributor
There was a problem hiding this comment.
This one is invalid because there's no default clause - was there something specific to the behavior analysis that it was supposed to be testing instead?
|
|
||
| const kInvalidFunctions = { | ||
| next_for_type: `fn foo() -> bool { }`, | ||
| next_return_for_type: `fn foo() -> bool { if true { return true } }`, |
Contributor
There was a problem hiding this comment.
Missing semicolon on the return statement, might cause it to be rejected for the wrong reasons.
alan-baker
force-pushed
the
statement-behavior
branch
from
f5e1dcb to
0cc75da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.