Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'args' and 'must_use' validation tests for several builtins #3503

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Mar 14, 2024

Responds to review feedback on sin, cos tests.

Updates:
dot4IPacked
dot4UPacked
floor
pack4xI8
pack4xI8Clamp
pack4xU8
pack4xU8Clamp
unpack4xI8
unpack4xU8

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@dneto0 dneto0 marked this pull request as draft March 14, 2024 17:32
@dneto0 dneto0 requested a review from ben-clayton March 15, 2024 17:13
@dneto0 dneto0 marked this pull request as ready for review March 15, 2024 17:13
@dneto0 dneto0 enabled auto-merge (squash) March 15, 2024 17:13
Responds to review feedback on sin, cos tests.

Updates:
 dot4IPacked
 dot4UPacked
 floor
 pack4xI8
 pack4xI8Clamp
 pack4xU8
 pack4xU8Clamp
 unpack4xI8
 unpack4xU8
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find the numbers in the field names confusing, but otherwise LGTM!

@dneto0 dneto0 merged commit 10e77ea into gpuweb:main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants