Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op: Add depthSlice tests in rendering/3d_texture_slices.spec.ts #3501

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

haoxli
Copy link
Contributor

@haoxli haoxli commented Mar 14, 2024

Add operation tests for depthSlice with mipLevels in color attachments.

Issue: #3144


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@haoxli haoxli force-pushed the op-depth-slice branch 3 times, most recently from 04ec212 to b140619 Compare March 14, 2024 08:07
@haoxli haoxli requested a review from kainino0x March 14, 2024 08:21
haoxli added 2 commits March 22, 2024 18:39
Add operation tests for depthSlice with mipLevels in color attachments.

Issue: gpuweb#3144
@kainino0x kainino0x enabled auto-merge (squash) March 22, 2024 19:20
@kainino0x kainino0x merged commit f1ae1f5 into gpuweb:main Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants