Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSL validation tests for textureSampleBias #3499

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

greggman
Copy link
Contributor


Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from ben-clayton March 14, 2024 00:38
@greggman
Copy link
Contributor Author

greggman commented Mar 14, 2024

I wasn't sure what to do about the abstract-int thing. I passed in 15.99 because it's mentioned in the spec but BigInt(15.99) throws with "not in integer". I could do Math.round or Math.ceil or something in Type.create but decided on acceptsFloat as one solution.

@greggman greggman force-pushed the textureSampleBias branch 2 times, most recently from baf7444 to 9810c44 Compare March 15, 2024 00:22
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. I can't navigate github's UI.

src/webgpu/util/conversion.ts Outdated Show resolved Hide resolved
@greggman greggman force-pushed the textureSampleBias branch from 9810c44 to 1282c1e Compare March 15, 2024 20:42
@greggman greggman merged commit 3c568c6 into gpuweb:main Mar 15, 2024
1 check passed
@greggman greggman deleted the textureSampleBias branch March 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants