Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shader/execution: Fix struct padding for f16s #3488

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

ben-clayton
Copy link
Contributor

@ben-clayton ben-clayton commented Mar 13, 2024

wgslMembers() was using an i32 to pad the structure to its alignment, however i32 has an alignment and size of 4 bytes. If the structure holds an odd number of f16 scalars, then i32 cannot be used for this padding due to the 4-byte size and alignment. Pad with f16 if the padding is an odd multiple of 2 bytes.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

`wgslMembers()` was using an `i32` to pad the structure to its alignment, however `i32` has an alignment and size of 4 bytes.
If the structure holds an odd number of `f16` scalars, then `i32` cannot be used to account fo this padding due to the 4-byte size and alignment.
Pad with `f16` if the padding is an odd multiple of 2 bytes.
@ben-clayton ben-clayton merged commit 392da47 into gpuweb:main Mar 13, 2024
1 check passed
@ben-clayton ben-clayton deleted the fix-struct-padding branch March 13, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants