Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ULP & Absolute Error support for AF #3487

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

zoddicus
Copy link
Contributor

For AbstractFloat, builtins that have absolute or ULP errors, (or inherit their error) should defer to the intervals for f32, so replacing the underlying intervals with stubs that assert instead.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Mar 12, 2024
@zoddicus zoddicus requested review from ben-clayton and dneto0 March 12, 2024 20:45
@zoddicus zoddicus self-assigned this Mar 12, 2024
@zoddicus
Copy link
Contributor Author

PTAL, this removes some framework code I recently added incorrectly. After re-reading the spec and talking with @dneto0 I believe I have an appropriate path forward.

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For AbstractFloat, builtins that have absolute or ULP errors, (or
inherit their error) should defer to the intervals for f32, so
replacing the underlying intervals with stubs that assert instead.
@zoddicus zoddicus force-pushed the removeAFComplexErrors branch from 6f00bd1 to 931433f Compare March 13, 2024 16:20
@zoddicus zoddicus merged commit 022bbf5 into gpuweb:main Mar 13, 2024
1 check passed
@zoddicus zoddicus deleted the removeAFComplexErrors branch March 13, 2024 16:25
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 18, 2024
For AbstractFloat, builtins that have absolute or ULP errors, (or
inherit their error) should defer to the intervals for f32, so
replacing the underlying intervals with stubs that assert instead.
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 18, 2024
For AbstractFloat, builtins that have absolute or ULP errors, (or
inherit their error) should defer to the intervals for f32, so
replacing the underlying intervals with stubs that assert instead.
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 19, 2024
For AbstractFloat, builtins that have absolute or ULP errors, (or
inherit their error) should defer to the intervals for f32, so
replacing the underlying intervals with stubs that assert instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants