Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSL: Add unary arithmetic negation validation tests. #3480

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Kangz
Copy link
Collaborator

@Kangz Kangz commented Mar 12, 2024

Also adds a signed : boolean to ScalarType.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@Kangz Kangz requested a review from jrprice March 12, 2024 15:30
@Kangz Kangz force-pushed the validation-artihmetic-negation branch 2 times, most recently from 12ea727 to 1f1fd22 Compare March 12, 2024 15:46
Also adds a signed : boolean to ScalarType.
@Kangz Kangz force-pushed the validation-artihmetic-negation branch from 1f1fd22 to 7e7c432 Compare March 15, 2024 18:02
@Kangz Kangz merged commit ff23e05 into gpuweb:main Mar 15, 2024
1 check passed
@Kangz Kangz deleted the validation-artihmetic-negation branch March 15, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants