Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add gen_listings.ts #3479

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Re-add gen_listings.ts #3479

merged 1 commit into from
Mar 12, 2024

Conversation

ben-clayton
Copy link
Contributor

@ben-clayton ben-clayton commented Mar 12, 2024

Chromium build infrastructure depends on this file. In order to migrate to the new gen_listings_and_webworkers.ts, we need to do a N-way patch.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Chromium build infrastructure depends on this file. In order to migrate to the new `gen_listings_and_webworkers.ts`, we need to do a N-way patch.
@ben-clayton ben-clayton requested a review from Kangz March 12, 2024 12:26
@ben-clayton ben-clayton enabled auto-merge (rebase) March 12, 2024 12:28
@ben-clayton ben-clayton merged commit 40acabf into gpuweb:main Mar 12, 2024
1 check passed
@ben-clayton ben-clayton deleted the gen_listings branch March 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants