Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Implement AbstractFloat determinant execution tests #3474

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

zoddicus
Copy link
Contributor

Fixes #2523


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Mar 11, 2024
@zoddicus zoddicus self-assigned this Mar 11, 2024
@zoddicus zoddicus force-pushed the addAFDeterminateTests branch from d24022b to c893b20 Compare March 12, 2024 17:00
@zoddicus zoddicus merged commit 9db2fcf into gpuweb:main Mar 12, 2024
1 check passed
@zoddicus zoddicus deleted the addAFDeterminateTests branch March 12, 2024 17:07
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 18, 2024
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 18, 2024
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: AbstractFloat execution test for determinant builtin
3 participants