-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discard shader execution tests #3467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I'm missing something, but the shader logic and/or predicates seem off for a couple of tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fragment positions LGTM now, but I'm still a little concerned about the fact that a couple of the tests don't fail if you make discards unconditional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Tests: * discard all * discard 3 quadrants * discard in function call * discard in various loops * derivatives and discard
* Fix test description * Fix coordinates used by fragment shader
* Initialize the framebuffer with a sentinel value * Modify checkers to detect sentinel value as no write instead of zero * Update function call test to use integer coords
9224ce3
to
632ba3c
Compare
Issue: #1683
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.