Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard shader execution tests #3467

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Mar 8, 2024

  • Tests:
    • discard all
    • discard 3 quadrants
    • discard in function call
    • discard in various loops
    • derivatives and discard

Issue: #1683


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested review from jrprice and dneto0 March 8, 2024 15:40
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I'm missing something, but the shader logic and/or predicates seem off for a couple of tests.

src/webgpu/shader/execution/statement/discard.spec.ts Outdated Show resolved Hide resolved
src/webgpu/shader/execution/statement/discard.spec.ts Outdated Show resolved Hide resolved
src/webgpu/shader/execution/statement/discard.spec.ts Outdated Show resolved Hide resolved
@alan-baker alan-baker requested a review from jrprice March 13, 2024 14:33
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fragment positions LGTM now, but I'm still a little concerned about the fact that a couple of the tests don't fail if you make discards unconditional.

@alan-baker alan-baker requested a review from jrprice March 14, 2024 16:15
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

src/webgpu/shader/execution/statement/discard.spec.ts Outdated Show resolved Hide resolved
* Tests:
  * discard all
  * discard 3 quadrants
  * discard in function call
  * discard in various loops
  * derivatives and discard
* Fix test description
* Fix coordinates used by fragment shader
* Initialize the framebuffer with a sentinel value
* Modify checkers to detect sentinel value as no write instead of zero
* Update function call test to use integer coords
@alan-baker alan-baker enabled auto-merge (squash) March 14, 2024 16:38
@alan-baker alan-baker merged commit c0769ae into gpuweb:main Mar 14, 2024
1 check passed
@alan-baker alan-baker deleted the discard-execution branch March 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants