Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Use selectNCases to restrict the number of AF Matrix cases #3465

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

zoddicus
Copy link
Contributor

@zoddicus zoddicus commented Mar 7, 2024

Fixes #3457


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Mar 7, 2024
@zoddicus zoddicus requested review from dj2 and ben-clayton March 7, 2024 21:23
@zoddicus zoddicus self-assigned this Mar 7, 2024
@zoddicus zoddicus force-pushed the reduceAFMatrixTests branch from 6e6a92f to 38c919d Compare March 11, 2024 15:04
@zoddicus zoddicus merged commit 11d3770 into gpuweb:main Mar 11, 2024
1 check passed
@zoddicus zoddicus deleted the reduceAFMatrixTests branch March 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: Apply case reduction, selectNCases to various AF Matrix tests
2 participants