Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Replace CaseList with Case[] #3463

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

zoddicus
Copy link
Contributor

@zoddicus zoddicus commented Mar 7, 2024

Fixes #3458


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus requested a review from ben-clayton March 7, 2024 19:33
@zoddicus
Copy link
Contributor Author

zoddicus commented Mar 7, 2024

PTAL, my brain always goes CaseList should be Case[] when I am looking at code that uses it, so I made a PR that changes it.

I think this is more idiomatic, but don't actually feel super strongly about it being 'correct'. If you prefer having the CaseList type, I will just abandon this and hopefully stop thinking I should change CaseList to Case[].

@zoddicus zoddicus merged commit ee19c8b into gpuweb:main Mar 7, 2024
1 check passed
@zoddicus zoddicus deleted the removeCaseList branch March 7, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate replacing CaseList with Case[]
2 participants