Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abs parameter validation. #3455

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add abs parameter validation. #3455

merged 2 commits into from
Mar 6, 2024

Conversation

dj2
Copy link
Member

@dj2 dj2 commented Mar 6, 2024

This CL adds validation for invalid abs parameters.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This CL adds validation for invalid `abs` parameters.
@dj2 dj2 added the wgsl label Mar 6, 2024
@dj2 dj2 requested a review from zoddicus March 6, 2024 17:12
@dj2 dj2 self-assigned this Mar 6, 2024
@dj2 dj2 merged commit 3dcdba7 into gpuweb:main Mar 6, 2024
1 check passed
@dj2 dj2 deleted the abs_val branch March 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants