Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader validation tests for atomics #3452

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Mar 4, 2024

  • type validation tests
    • address space
    • type
    • invalid operations
  • builtin function tests
    • atomic parameterizations
    • data types
    • return types

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

* type validation tests
  * address space
  * type
  * invalid operations
* builtin function tests
  * parameterizations
@alan-baker alan-baker requested a review from amaiorano March 4, 2024 19:37
* Data type validation
* Return type validation
@alan-baker alan-baker requested a review from dneto0 March 6, 2024 15:53
Copy link
Member

@amaiorano amaiorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this in my inbox.

@amaiorano amaiorano enabled auto-merge (rebase) March 8, 2024 18:46
@amaiorano amaiorano merged commit 1d5dd49 into gpuweb:main Mar 8, 2024
1 check passed
@alan-baker alan-baker deleted the atomic-val branch March 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants