Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Implement AbstractFloat ceil execution tests #3449

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

zoddicus
Copy link
Contributor

Issue #1297


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Feb 29, 2024
@zoddicus zoddicus self-assigned this Feb 29, 2024
abstract: [
{ input: 2 ** 52, expected: 2 ** 52 },
{ input: -(2 ** 52), expected: -(2 ** 52) },
{ input: 0x80000000, expected: 0x80000000 }, // https://github.com/gpuweb/cts/issues/2766
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For abstract, shouldn't this be 0x8000000000000000n ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zoddicus zoddicus force-pushed the addAbstractFloatCeilTests branch 2 times, most recently from e34294c to d6dc01e Compare February 29, 2024 19:05
@zoddicus zoddicus requested a review from ben-clayton March 6, 2024 18:40
@zoddicus zoddicus force-pushed the addAbstractFloatCeilTests branch from d6dc01e to f4317ba Compare March 11, 2024 15:38
@zoddicus zoddicus merged commit e91b44a into gpuweb:main Mar 11, 2024
1 check passed
@zoddicus zoddicus deleted the addAbstractFloatCeilTests branch March 11, 2024 15:44
ben-clayton pushed a commit to ben-clayton/cts that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants