Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation tests for resource compatibility of render pipelines #3441

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Feb 28, 2024

  • Reuses compute pipeline resource infrastructure
    • small update to generate consistent fragment shader
  • Filters out writable storge buffer and storage texture resources from the api side for vertex shaders

Followup to #3431.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested a review from kainino0x February 28, 2024 15:24
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Reuses compute pipeline resource infrastructure
  * small update to generate consistent fragment shader
* Filters out writable storge buffer and storage texture resources from
  the api side for vertex shaders
@alan-baker alan-baker force-pushed the resource-compat-render branch from f9629de to 1e1ea22 Compare February 28, 2024 22:40
@alan-baker alan-baker enabled auto-merge (squash) February 28, 2024 22:40
@alan-baker alan-baker merged commit c0181cf into gpuweb:main Feb 28, 2024
1 check passed
@alan-baker alan-baker deleted the resource-compat-render branch February 28, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants